[rc-swift] Start RC Swift implementation #13931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Apple API Diff ReportCommit: fd2c8fb FirebaseRemoteConfigClassesFIRRemoteConfig[MODIFIED] -addOnConfigUpdateListener:Swift:
+ func addOnConfigUpdateListener ( remoteConfigUpdateCompletion listener : @escaping ( FIRRemoteConfigUpdate ?, ( any Error )?) -> Void ) -> ConfigUpdateListenerRegistration
- func addOnConfigUpdateListener ( remoteConfigUpdateCompletion listener : @escaping ( RemoteConfigUpdate ?, ( any Error )?) -> Void ) -> ConfigUpdateListenerRegistration
Objective-C:
+ - ( FIRConfigUpdateListenerRegistration * _Nonnull ) addOnConfigUpdateListener : ( FIRRemoteConfigUpdateCompletion _Nonnull ) listener ;
- - ( FIRConfigUpdateListenerRegistration * _Nonnull ) addOnConfigUpdateListener : ( FIRRemoteConfigUpdateCompletion _Nonnull ) listener ;[REMOVED] FIRRemoteConfigUpdate[REMOVED] FIRRemoteConfigUpdateSwift:
- var updatedKeys : Set < String > { get }
Objective-C:
- @property ( nonatomic , readonly , nonnull ) NSSet < NSString *> * updatedKeys ; |
andrewheard
approved these changes
Oct 23, 2024
|
Going to merge and can address any future comments in future |
paulb777
added a commit
that referenced
this pull request
Oct 23, 2024
paulb777
added a commit
that referenced
this pull request
Oct 31, 2024
paulb777
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The first pass of the implementation is not worrying about access levels. Extra public's and
@objcdeclarations so that the ObjC unit tests can continue to run.